Re: [PATCH v3 2/4] misc: pci_endpoint_test: Fix the return value of IOCTL

[Damien Le Moal]

On 12/11/24 5:01 PM, Manivannan Sadhasivam wrote:
>  struct pci_test {
> @@ -52,63 +51,65 @@ static int run_test(struct pci_test *test)
>  		ret = ioctl(fd, PCITEST_BAR, test->barnum);
>  		fprintf(stdout, "BAR%d:\t\t", test->barnum);
>  		if (ret < 0)
> -			fprintf(stdout, "TEST FAILED\n");
> +			fprintf(stdout, "NOT OKAY\n");
>  		else
> -			fprintf(stdout, "%s\n", result[ret]);
> +			fprintf(stdout, "OKAY\n");

Why not simplify as I suggested to avoid all these repetitive (and ugly) "if ()
else" ?


-- 
Damien Le Moal
Western Digital Research