Re: [PATCH] net: dsa: tag_ocelot_8021q: fix broken reception
From: Andrew Lunn
Date: Wed Dec 11 2024 - 08:34:28 EST
On Wed, Dec 11, 2024 at 01:46:56PM +0100, Robert Hodaszi wrote:
> Commit dcfe7673787b4bfea2c213df443d312aa754757b ("net: dsa: tag_sja1105:
> absorb logic for not overwriting precise info into dsa_8021q_rcv()")
> added support to let the DSA switch driver set source_port and
> switch_id. tag_8021q's logic overrides the previously set source_port
> and switch_id only if they are marked as "invalid" (-1). sja1105 and
> vsc73xx drivers are doing that properly, but ocelot_8021q driver doesn't
> initialize those variables. That causes dsa_8021q_rcv() doesn't set
> them, and they remain unassigned.
>
> Initialize them as invalid to so dsa_8021q_rcv() can return with the
> proper values.
Hi Robert
Since this is a fix, it needs a Fixes: tag. Please also base it on net.
There is more here:
https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html
Andrew