Re: [PATCH net-next v2 1/2] dt-bindings: net: dp83822: Add support for GPIO2 clock output

[Krzysztof Kozlowski]

On 11/12/2024 11:51, Dimitri Fedrau wrote:
>>> +
>>> +/* IO_MUX_GPIO_CTRL - Clock source selection */
>>> +#define DP83822_CLK_SRC_MAC_IF			0x0
>>> +#define DP83822_CLK_SRC_XI			0x1
>>> +#define DP83822_CLK_SRC_INT_REF			0x2
>>> +#define DP83822_CLK_SRC_RMII_MASTER_MODE_REF	0x4
>>> +#define DP83822_CLK_SRC_FREE_RUNNING		0x6
>>> +#define DP83822_CLK_SRC_RECOVERED		0x7
>>
>> These are not really bindings but some register values. Hex numbers
>> indicate that. Don't store register values as bindings, because this
>> is neither necessary nor helping.
>>
> Ok, got it. Have seen similar in <dt-bindings/net/ti-dp83867.h> or
> <dt-bindings/net/ti-dp83869.h>, is it wrong there ?


Yes, it is. Rules were much more relaxed 10 years ago but these were not
even sent for DT review and did not receive any ack/review.
> 
> Best regards,
> Dimitri Fedrau


Best regards,
Krzysztof