RE: [PATCH 5/8] arm64: dts: qcom: x1e80100-dell-xps13-9345: Fix USB QMP PHY supplies

From: Tudor, Laurentiu
Date: Wed Dec 11 2024 - 08:45:29 EST



Internal Use - Confidential
+AD4- -----Original Message-----
+AD4- From: Aleksandrs Vinarskis +ADw-alex.vinarskis+AEA-gmail.com+AD4-
+AD4- Sent: Tuesday, December 10, 2024 10:45 PM
+AD4-
+AD4- On Tue, 10 Dec 2024 at 10:07, Stephan Gerhold +ADw-stephan.gerhold+AEA-linaro.org+AD4-
+AD4- wrote:
+AD4- +AD4-
+AD4- +AD4- On the X1E80100 CRD, +ACY-vreg+AF8-l3e+AF8-1p2 only powers +ACY-usb+AF8-mp+AF8-qmpphy0/1
+AD4- (i.e.
+AD4- +AD4- USBSS+AF8-3 and USBSS+AF8-4). The QMP PHYs for USB+AF8-0, USB+AF8-1 and USB+AF8-2 are
+AD4- +AD4- actually powered by +ACY-vreg+AF8-l2j+AF8-1p2.
+AD4- +AD4-
+AD4- +AD4- Since x1e80100-dell-xps13-9345 mostly just mirrors the power supplies
+AD4- +AD4- from the x1e80100-crd device tree, assume that the fix also applies here.
+AD4-
+AD4- Though I can't verify schematics (perhaps Laurentiu can?)can confirm USBs
+AD4- still work as expected with this change.

Yep, just checked the schematics and can confirm.

---
Best Regards, Laurentiu

+AD4- Tested-by: Aleksandrs Vinarskis +ADw-alex.vinarskis+AEA-gmail.com+AD4-
+AD4-
+AD4- +AD4-
+AD4- +AD4- Cc: stable+AEA-vger.kernel.org
+AD4- +AD4- Fixes: f5b788d0e8cd (+ACI-arm64: dts: qcom: Add support for X1-based Dell
+AD4- +AD4- XPS 13 9345+ACI-)
+AD4- +AD4- Signed-off-by: Stephan Gerhold +ADw-stephan.gerhold+AEA-linaro.org+AD4-
+AD4- +AD4- ---
+AD4- +AD4- arch/arm64/boot/dts/qcom/x1e80100-dell-xps13-9345.dts +AHw- 4 +-+---
+AD4- +AD4- 1 file changed, 2 insertions(+-), 2 deletions(-)
+AD4- +AD4-
+AD4- +AD4- diff --git a/arch/arm64/boot/dts/qcom/x1e80100-dell-xps13-9345.dts
+AD4- +AD4- b/arch/arm64/boot/dts/qcom/x1e80100-dell-xps13-9345.dts
+AD4- +AD4- index
+AD4- +AD4-
+AD4- b112092fbb9fd955adca1ae8a76294c776fa2d1e..1aec536218bc2c9197410a4
+AD4- 3adec
+AD4- +AD4- 291a31f9beed 100644
+AD4- +AD4- --- a/arch/arm64/boot/dts/qcom/x1e80100-dell-xps13-9345.dts
+AD4- +AD4- +-+-+- b/arch/arm64/boot/dts/qcom/x1e80100-dell-xps13-9345.dts
+AD4- +AD4- +AEAAQA- -1093,7 +-1093,7 +AEAAQA- +ACY-usb+AF8-1+AF8-ss0+AF8-hsphy +AHs- +AH0AOw-
+AD4- +AD4-
+AD4- +AD4- +ACY-usb+AF8-1+AF8-ss0+AF8-qmpphy +AHs-
+AD4- +AD4- - vdda-phy-supply +AD0- +ADwAJg-vreg+AF8-l3e+AF8-1p2+AD4AOw-
+AD4- +AD4- +- vdda-phy-supply +AD0- +ADwAJg-vreg+AF8-l2j+AF8-1p2+AD4AOw-
+AD4- +AD4- vdda-pll-supply +AD0- +ADwAJg-vreg+AF8-l1j+AF8-0p9+AD4AOw-
+AD4- +AD4-
+AD4- +AD4- status +AD0- +ACI-okay+ACIAOw-
+AD4- +AD4- +AEAAQA- -1125,7 +-1125,7 +AEAAQA- +ACY-usb+AF8-1+AF8-ss1+AF8-hsphy +AHs- +AH0AOw-
+AD4- +AD4-
+AD4- +AD4- +ACY-usb+AF8-1+AF8-ss1+AF8-qmpphy +AHs-
+AD4- +AD4- - vdda-phy-supply +AD0- +ADwAJg-vreg+AF8-l3e+AF8-1p2+AD4AOw-
+AD4- +AD4- +- vdda-phy-supply +AD0- +ADwAJg-vreg+AF8-l2j+AF8-1p2+AD4AOw-
+AD4- +AD4- vdda-pll-supply +AD0- +ADwAJg-vreg+AF8-l2d+AF8-0p9+AD4AOw-
+AD4- +AD4-
+AD4- +AD4- status +AD0- +ACI-okay+ACIAOw-
+AD4- +AD4-
+AD4- +AD4- --
+AD4- +AD4- 2.47.0
+AD4- +AD4-