Re: [PATCH v7 2/3] clk: qcom: common: Add support for power-domain attachment

[Bryan O'Donoghue]

On 11/12/2024 13:36, Vladimir Zapolskiy wrote:
> > +    struct dev_pm_domain_attach_data pd_data = {
> > +        .pd_names = 0,
> > +        .num_pd_names = 0,
> > +    };
>
> Please remove the added local variable.
>
> >       cc = devm_kzalloc(dev, sizeof(*cc), GFP_KERNEL);
> >       if (!cc)
> >           return -ENOMEM;
> > +    ret = devm_pm_domain_attach_list(dev, &pd_data, &cc->pd_list);
>
> Please simplify it to
>
>      ret = devm_pm_domain_attach_list(dev, NULL, &cc->pd_list);

My apologies, I cherry-picked the wrong version of this patch from my 
working tree to my b4/send tree.

---
bod