Re: [PATCH v2 2/2] thermal: imx91: Add support for i.MX91 thermal monitoring unit
From: Fabio Estevam
Date: Wed Dec 11 2024 - 10:59:26 EST
On Tue, Dec 10, 2024 at 6:27 PM Frank Li <Frank.Li@xxxxxxx> wrote:
> +#define CTRL0 0x0
> +
> +#define STAT0 0x10
...
> +#define DATA0 0x20
These generic short macro names can easily clash in the future.
It would be better to add a better namespace definition.
For example:
IMX91_THERMAL_CTRL0
IMX91_THERMAL_STAT0
IMX91_THERMAL_DATA0