Re: [PATCH v2 1/2] perf probe: Fix uninitialized variable

From: Namhyung Kim
Date: Wed Dec 11 2024 - 12:18:55 EST


Hello,

On Wed, Dec 11, 2024 at 10:15:30AM -0300, Arnaldo Carvalho de Melo wrote:
> On Wed, Dec 11, 2024 at 08:55:23AM +0000, James Clark wrote:
> > Since the linked fixes: commit, err is returned uninitialized due to the
> > removal of "return 0". Initialize err to fix it.
> >
> > This fixes the following intermittent test failure on release builds:
> >
> > $ perf test "testsuite_probe"
> > ...
> > -- [ FAIL ] -- perf_probe :: test_invalid_options :: mutually exclusive options :: -L foo -V bar (output regexp parsing)
> > Regexp not found: \"Error: switch .+ cannot be used with switch .+\"
> > ...
>
> So Namhyung, this one should go to perf-tools, I can pick the second on
> perf-tools-next, so that we keep perf-tools as small as possible.

Sure, will replace and force-push.

Thanks,
Namhyung