Re: [PATCH v2 09/14] drm/msm/dp: use msm_dp_utils_pack_sdp_header() for audio packets

[Stephen Boyd]

Quoting Dmitry Baryshkov (2024-12-02 02:06:39)
> Use msm_dp_utils_pack_sdp_header() and call msm_dp_write_link() directly
> to program audio packet data. Use 0 as Packet ID, as it was not
> programmed earlier.
>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
> ---

Reviewed-by: Stephen Boyd <swboyd@xxxxxxxxxxxx>

> diff --git a/drivers/gpu/drm/msm/dp/dp_audio.c b/drivers/gpu/drm/msm/dp/dp_audio.c
> index 5cbb11986460d1e4ed1890bdf66d0913e013083c..1aa52d5cc08684a49102e45ed6e40ac2b13497c7 100644
> --- a/drivers/gpu/drm/msm/dp/dp_audio.c
> +++ b/drivers/gpu/drm/msm/dp/dp_audio.c
[...]
> +               .HB0 = 0x00,
> +               .HB1 = 0x06,
> +               .HB2 = 0x0f,
> +               .HB3 = 0x00,
> +       };
> +       u32 header[2];
> +       u32 reg;
> +
> +       /* XXX: is it necessary to preserve this field? */

Maybe qcom can comment.

> +       reg = msm_dp_read_link(catalog, MMSS_DP_AUDIO_ISRC_1);
> +       sdp_hdr.HB3 = FIELD_GET(HEADER_3_MASK, reg);
> +
> +       msm_dp_utils_pack_sdp_header(&sdp_hdr, header);
> +