Re: [PATCH 08/16] media: qcom: camss: vfe: Move common code into vfe core

[Vladimir Zapolskiy]

Hi Depeng.

On 12/11/24 16:07, Depeng Shao wrote:
> Some v4l2 buffer related logic functions can be moved to vfe core as
> common code, then the vfe driver of different hw version can reuse them,
> this also can avoid adding duplicate code for new version supporting.
>
> Suggested-by: Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx>
> Signed-off-by: Depeng Shao <quic_depengs@xxxxxxxxxxx>
> ---
>   .../media/platform/qcom/camss/camss-vfe-17x.c | 112 +------
>   .../media/platform/qcom/camss/camss-vfe-4-1.c |   9 -
>   .../media/platform/qcom/camss/camss-vfe-4-7.c |  11 -
>   .../media/platform/qcom/camss/camss-vfe-4-8.c |  11 -
>   .../media/platform/qcom/camss/camss-vfe-480.c | 301 +++---------------
>   drivers/media/platform/qcom/camss/camss-vfe.c | 276 +++++++++++++++-
>   drivers/media/platform/qcom/camss/camss-vfe.h |  57 +++-
>   7 files changed, 376 insertions(+), 401 deletions(-)

I've spent some time on regression testing, and bisected that this particular
change breaks TPG on SM8250 (RB5 board and navigation mezzanine), but in
a different way than in v4 or v5, namely frames are not captured at all.

This change consists of multiple logically independent parts, it would be
good to see them split into separate changes and get the regression fixed.

This is a massive and a functional change, since it causes a regression,
it might be better to make the change non-functional.

--
Best wishes,
Vladimir