Re: [PATCH v2] cpupower: fix TSC MHz calculation for Mperf monitor

[He Rongguang]

在 2024/12/12 4:54, Shuah Khan 写道:
> 
> Are you sure you sent me the right patch. I am seeing exact
> same errors. How are you sending your patches.
> 
> Here are the problems I am seeing:
> 
> ERROR: patch seems to be corrupt (line wrapped?)
> #103: FILE: :173:
> double *percent,
> 
> WARNING: It's generally not useful to have the filename in the file
> #108: FILE: :177:
> +        timediff = max_frequency * timespec_diff_us(time_start[cpu],
> 
> WARNING: It's generally not useful to have the filename in the file
> #119: FILE: :210:
> +        time_diff = timespec_diff_us(time_start[cpu], time_end[cpu]);
> 
> WARNING: It's generally not useful to have the filename in the file
> #130: FILE: :230:
> +        clock_gettime(CLOCK_REALTIME, &time_start[cpu]);
> 
> WARNING: It's generally not useful to have the filename in the file
> #138: FILE: :245:
> +        clock_gettime(CLOCK_REALTIME, &time_end[cpu]);
> 
> WARNING: It's generally not useful to have the filename in the file
> #149: FILE: :351:
> +    time_start = calloc(cpu_count, sizeof(struct timespec));
> 
> WARNING: It's generally not useful to have the filename in the file
> #150: FILE: :352:
> +    time_end = calloc(cpu_count, sizeof(struct timespec));
> 
> WARNING: It's generally not useful to have the filename in the file
> #158: FILE: :365:
> +    free(time_start);
> 
> WARNING: It's generally not useful to have the filename in the file
> #159: FILE: :366:
> +    free(time_end);
> 
> thanks,
> -- Shuah

I am very sorry, it's thunderbird auto wrap my patch, sent a v3, currently seems ok:

$ ./scripts/checkpatch.pl test.patch
total: 0 errors, 0 warnings, 60 lines checked

test.patch has no obvious style problems and is ready for submission.