drivers/nvmem/zynqmp_nvmem.c:123 zynqmp_efuse_access() error: uninitialized symbol 'ret'.
From: Dan Carpenter
Date: Thu Dec 12 2024 - 02:44:37 EST
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 231825b2e1ff6ba799c5eaf396d3ab2354e37c6b
commit: 737c0c8d07b5f671c0a33cec95965fcb2d2ea893 nvmem: zynqmp_nvmem: Add support to access efuse
config: arm64-randconfig-r072-20241210 (https://download.01.org/0day-ci/archive/20241212/202412121555.Fp663tyH-lkp@xxxxxxxxx/config)
compiler: clang version 18.1.8 (https://github.com/llvm/llvm-project 3b5b5c1ec4a3095ab096dd780e84d7ab81f3d7ff)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
| Closes: https://lore.kernel.org/r/202412121555.Fp663tyH-lkp@xxxxxxxxx/
smatch warnings:
drivers/nvmem/zynqmp_nvmem.c:123 zynqmp_efuse_access() error: uninitialized symbol 'ret'.
vim +/ret +123 drivers/nvmem/zynqmp_nvmem.c
737c0c8d07b5f67 Praveen Teja Kundanala 2024-02-24 59 static int zynqmp_efuse_access(void *context, unsigned int offset,
737c0c8d07b5f67 Praveen Teja Kundanala 2024-02-24 60 void *val, size_t bytes, enum efuse_access flag,
737c0c8d07b5f67 Praveen Teja Kundanala 2024-02-24 61 unsigned int pufflag)
737c0c8d07b5f67 Praveen Teja Kundanala 2024-02-24 62 {
737c0c8d07b5f67 Praveen Teja Kundanala 2024-02-24 63 struct device *dev = context;
737c0c8d07b5f67 Praveen Teja Kundanala 2024-02-24 64 struct xilinx_efuse *efuse;
737c0c8d07b5f67 Praveen Teja Kundanala 2024-02-24 65 dma_addr_t dma_addr;
737c0c8d07b5f67 Praveen Teja Kundanala 2024-02-24 66 dma_addr_t dma_buf;
737c0c8d07b5f67 Praveen Teja Kundanala 2024-02-24 67 size_t words = bytes / WORD_INBYTES;
737c0c8d07b5f67 Praveen Teja Kundanala 2024-02-24 68 int ret;
737c0c8d07b5f67 Praveen Teja Kundanala 2024-02-24 69 int value;
737c0c8d07b5f67 Praveen Teja Kundanala 2024-02-24 70 char *data;
737c0c8d07b5f67 Praveen Teja Kundanala 2024-02-24 71
737c0c8d07b5f67 Praveen Teja Kundanala 2024-02-24 72 if (bytes % WORD_INBYTES != 0) {
737c0c8d07b5f67 Praveen Teja Kundanala 2024-02-24 73 dev_err(dev, "Bytes requested should be word aligned\n");
737c0c8d07b5f67 Praveen Teja Kundanala 2024-02-24 74 return -EOPNOTSUPP;
737c0c8d07b5f67 Praveen Teja Kundanala 2024-02-24 75 }
737c0c8d07b5f67 Praveen Teja Kundanala 2024-02-24 76
737c0c8d07b5f67 Praveen Teja Kundanala 2024-02-24 77 if (pufflag == 0 && offset % WORD_INBYTES) {
737c0c8d07b5f67 Praveen Teja Kundanala 2024-02-24 78 dev_err(dev, "Offset requested should be word aligned\n");
737c0c8d07b5f67 Praveen Teja Kundanala 2024-02-24 79 return -EOPNOTSUPP;
737c0c8d07b5f67 Praveen Teja Kundanala 2024-02-24 80 }
737c0c8d07b5f67 Praveen Teja Kundanala 2024-02-24 81
737c0c8d07b5f67 Praveen Teja Kundanala 2024-02-24 82 if (pufflag == 1 && flag == EFUSE_WRITE) {
737c0c8d07b5f67 Praveen Teja Kundanala 2024-02-24 83 memcpy(&value, val, bytes);
737c0c8d07b5f67 Praveen Teja Kundanala 2024-02-24 84 if ((offset == EFUSE_PUF_START_OFFSET ||
737c0c8d07b5f67 Praveen Teja Kundanala 2024-02-24 85 offset == EFUSE_PUF_MID_OFFSET) &&
737c0c8d07b5f67 Praveen Teja Kundanala 2024-02-24 86 value & P_USER_0_64_UPPER_MASK) {
737c0c8d07b5f67 Praveen Teja Kundanala 2024-02-24 87 dev_err(dev, "Only lower 4 bytes are allowed to be programmed in P_USER_0 & P_USER_64\n");
737c0c8d07b5f67 Praveen Teja Kundanala 2024-02-24 88 return -EOPNOTSUPP;
737c0c8d07b5f67 Praveen Teja Kundanala 2024-02-24 89 }
737c0c8d07b5f67 Praveen Teja Kundanala 2024-02-24 90
737c0c8d07b5f67 Praveen Teja Kundanala 2024-02-24 91 if (offset == EFUSE_PUF_END_OFFSET &&
737c0c8d07b5f67 Praveen Teja Kundanala 2024-02-24 92 (value & P_USER_127_LOWER_4_BIT_MASK)) {
737c0c8d07b5f67 Praveen Teja Kundanala 2024-02-24 93 dev_err(dev, "Only MSB 28 bits are allowed to be programmed for P_USER_127\n");
737c0c8d07b5f67 Praveen Teja Kundanala 2024-02-24 94 return -EOPNOTSUPP;
737c0c8d07b5f67 Praveen Teja Kundanala 2024-02-24 95 }
737c0c8d07b5f67 Praveen Teja Kundanala 2024-02-24 96 }
737c0c8d07b5f67 Praveen Teja Kundanala 2024-02-24 97
737c0c8d07b5f67 Praveen Teja Kundanala 2024-02-24 98 efuse = dma_alloc_coherent(dev, sizeof(struct xilinx_efuse),
737c0c8d07b5f67 Praveen Teja Kundanala 2024-02-24 99 &dma_addr, GFP_KERNEL);
737c0c8d07b5f67 Praveen Teja Kundanala 2024-02-24 100 if (!efuse)
737c0c8d07b5f67 Praveen Teja Kundanala 2024-02-24 101 return -ENOMEM;
737c0c8d07b5f67 Praveen Teja Kundanala 2024-02-24 102
737c0c8d07b5f67 Praveen Teja Kundanala 2024-02-24 103 data = dma_alloc_coherent(dev, sizeof(bytes),
737c0c8d07b5f67 Praveen Teja Kundanala 2024-02-24 104 &dma_buf, GFP_KERNEL);
737c0c8d07b5f67 Praveen Teja Kundanala 2024-02-24 105 if (!data) {
737c0c8d07b5f67 Praveen Teja Kundanala 2024-02-24 106 ret = -ENOMEM;
737c0c8d07b5f67 Praveen Teja Kundanala 2024-02-24 107 goto efuse_data_fail;
737c0c8d07b5f67 Praveen Teja Kundanala 2024-02-24 108 }
737c0c8d07b5f67 Praveen Teja Kundanala 2024-02-24 109
737c0c8d07b5f67 Praveen Teja Kundanala 2024-02-24 110 if (flag == EFUSE_WRITE) {
737c0c8d07b5f67 Praveen Teja Kundanala 2024-02-24 111 memcpy(data, val, bytes);
737c0c8d07b5f67 Praveen Teja Kundanala 2024-02-24 112 efuse->flag = EFUSE_WRITE;
737c0c8d07b5f67 Praveen Teja Kundanala 2024-02-24 113 } else {
737c0c8d07b5f67 Praveen Teja Kundanala 2024-02-24 114 efuse->flag = EFUSE_READ;
737c0c8d07b5f67 Praveen Teja Kundanala 2024-02-24 115 }
737c0c8d07b5f67 Praveen Teja Kundanala 2024-02-24 116
737c0c8d07b5f67 Praveen Teja Kundanala 2024-02-24 117 efuse->src = dma_buf;
737c0c8d07b5f67 Praveen Teja Kundanala 2024-02-24 118 efuse->size = words;
737c0c8d07b5f67 Praveen Teja Kundanala 2024-02-24 119 efuse->offset = offset;
737c0c8d07b5f67 Praveen Teja Kundanala 2024-02-24 120 efuse->pufuserfuse = pufflag;
737c0c8d07b5f67 Praveen Teja Kundanala 2024-02-24 121
737c0c8d07b5f67 Praveen Teja Kundanala 2024-02-24 122 zynqmp_pm_efuse_access(dma_addr, (u32 *)&ret);
In this .config the zynqmp_pm_efuse_access() is stubbed out so ret isn't
initialized.
737c0c8d07b5f67 Praveen Teja Kundanala 2024-02-24 @123 if (ret != 0) {
737c0c8d07b5f67 Praveen Teja Kundanala 2024-02-24 124 if (ret == EFUSE_NOT_ENABLED) {
737c0c8d07b5f67 Praveen Teja Kundanala 2024-02-24 125 dev_err(dev, "efuse access is not enabled\n");
737c0c8d07b5f67 Praveen Teja Kundanala 2024-02-24 126 ret = -EOPNOTSUPP;
737c0c8d07b5f67 Praveen Teja Kundanala 2024-02-24 127 } else {
737c0c8d07b5f67 Praveen Teja Kundanala 2024-02-24 128 dev_err(dev, "Error in efuse read %x\n", ret);
737c0c8d07b5f67 Praveen Teja Kundanala 2024-02-24 129 ret = -EPERM;
737c0c8d07b5f67 Praveen Teja Kundanala 2024-02-24 130 }
737c0c8d07b5f67 Praveen Teja Kundanala 2024-02-24 131 goto efuse_access_err;
737c0c8d07b5f67 Praveen Teja Kundanala 2024-02-24 132 }
737c0c8d07b5f67 Praveen Teja Kundanala 2024-02-24 133
737c0c8d07b5f67 Praveen Teja Kundanala 2024-02-24 134 if (flag == EFUSE_READ)
737c0c8d07b5f67 Praveen Teja Kundanala 2024-02-24 135 memcpy(val, data, bytes);
737c0c8d07b5f67 Praveen Teja Kundanala 2024-02-24 136 efuse_access_err:
737c0c8d07b5f67 Praveen Teja Kundanala 2024-02-24 137 dma_free_coherent(dev, sizeof(bytes),
737c0c8d07b5f67 Praveen Teja Kundanala 2024-02-24 138 data, dma_buf);
737c0c8d07b5f67 Praveen Teja Kundanala 2024-02-24 139 efuse_data_fail:
737c0c8d07b5f67 Praveen Teja Kundanala 2024-02-24 140 dma_free_coherent(dev, sizeof(struct xilinx_efuse),
737c0c8d07b5f67 Praveen Teja Kundanala 2024-02-24 141 efuse, dma_addr);
737c0c8d07b5f67 Praveen Teja Kundanala 2024-02-24 142
737c0c8d07b5f67 Praveen Teja Kundanala 2024-02-24 143 return ret;
737c0c8d07b5f67 Praveen Teja Kundanala 2024-02-24 144 }
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki