Re: [PATCH] printk: Fix signed integer overflow when defining LOG_BUF_LEN_MAX
From: Petr Mladek
Date: Thu Dec 12 2024 - 06:34:03 EST
On Sat 2024-09-28 19:36:08, Kuan-Wei Chiu wrote:
> Shifting 1 << 31 on a 32-bit int causes signed integer overflow, which
> leads to undefined behavior. To prevent this, cast 1 to u32 before
> performing the shift, ensuring well-defined behavior.
>
> This change explicitly avoids any potential overflow by ensuring that
> the shift occurs on an unsigned 32-bit integer.
>
> Signed-off-by: Kuan-Wei Chiu <visitorckw@xxxxxxxxx>
JFYI, the patch has been committed into printk/linux.git, branch
for-6.14.
Best Regards,
Petr
PS: I am terribly sorry for missing the merge window for 6.13.
The patch went away from my radar and I have somehow missed
even your reminder /o\