Re: [PATCH 12/16] dt-bindings: media: camss: Add qcom,sm8550-camss binding

[Depeng Shao]

Hi Bryan,

On 12/11/2024 11:17 PM, Bryan O'Donoghue wrote:
> On 11/12/2024 14:07, Depeng Shao wrote:
> > +            interconnects = <&gem_noc MASTER_APPSS_PROC 0 &config_noc 
> > SLAVE_CAMERA_CFG 0>,
> > +                            <&mmss_noc MASTER_CAMNOC_HF 0 &mc_virt 
> > SLAVE_EBI1 0>,
> > +                            <&mmss_noc MASTER_CAMNOC_ICP 0 &mc_virt 
> > SLAVE_EBI1 0>,
> > +                            <&mmss_noc MASTER_CAMNOC_SF 0 &mc_virt 
> > SLAVE_EBI1 0>;
>
> Have a look at 7280.
>
> The parameters to the NOC should be named.
>
> https://lore.kernel.org/all/20241206191900.2545069-2- 
> quic_vikramsa@xxxxxxxxxxx

Do you mean use QCOM_ICC_TAG_ACTIVE_ONLY and QCOM_ICC_TAG_ALWAYS?
And, I will also remove the ICP and SF interconnects which are used by 
offline HW, rather than real time VFE.

Thanks,
Depeng