Re: [PATCH v3] RAS/AMD/ATL: Fix unintended sign extension issue from coverity

[Konstantin Ryabitsev]

On Wed, Dec 11, 2024 at 11:01:13AM -0500, Yazen Ghannam wrote:
> One minor nit: the Reviewed-by tag should go after the Signed-off-by.
> This is noted in the "tip tree handbook":
> https://www.kernel.org/doc/html/latest/process/maintainer-tip.html#ordering-of-commit-tags

It depends on who is applying the trailer, because b4 uses the
"chain-of-custody" approach to trailer ordering:

https://lore.kernel.org/tools/20221031165842.vxr4kp6h7qnkc53l@meerkat.local/

The gist of that approach is that the "Signed-off-by" trailer indicates the
custody boundary. Anything above that line is the responsibility of the person
mentioned in the S-o-B. Anything below that line is the responsibility of the
person who is the next S-o-B.

> 
> The EDAC and RAS subsystems generally follow the "TIP" group guidelines,
> in my understanding.
> 
> I see you're using "b4", so you may want to adjust the "trailer-order"
> config option. I've been trying out b4 myself, so this is fresh in my
> mind.
> https://b4.docs.kernel.org/en/latest/config.html

The trailer-order config option will only apply within the custody boundary.

Best wishes,
-K