Re: [PATCH] modpost: distinguish same module paths from different dump files

[Masahiro Yamada]

On Fri, Dec 13, 2024 at 12:46 AM Masahiro Yamada <masahiroy@xxxxxxxxxx> wrote:
>
> Since commit 13b25489b6f8 ("kbuild: change working directory to external
> module directory with M="), module paths are always relative to the top
> of the external module tree.
>
> The module paths recorded in Module.symvers is no longer globally unique

    is -> are

> when they are passed via KBUILD_EXTRA_SYMBOLS for building other external
> modules, which may result in false positive "exported twice" errors.
> Such errors should not occur because external modules should be able to
> override in-tree modules.
>
> To address this, record the dump file path in struct module and check it
> when searching for a module.
>
> Fixes: 13b25489b6f8 ("kbuild: change working directory to external module directory with M=")
> Reported-by: Jon Hunter <jonathanh@xxxxxxxxxx>
> Closes: https://lore.kernel.org/all/eb21a546-a19c-40df-b821-bbba80f19a3d@xxxxxxxxxx/
> Signed-off-by: Masahiro Yamada <masahiroy@xxxxxxxxxx>
> ---


-- 
Best Regards
Masahiro Yamada