Re: [PATCH v6] lib/math: Add int_sqrt test suite

From: Luis Felipe Hernandez
Date: Thu Dec 12 2024 - 13:23:58 EST


On Wed, Dec 11, 2024 at 11:18:16PM -0800, Andrew Morton wrote:
> my x86_64 allmodconfig build says
>
> AR built-in.a
> AR vmlinux.a
> error: the following would cause module name conflict:
> lib/math/tests/int_pow_kunit.ko
> lib/math/tests/int_pow_kunit.ko
> make[1]: *** [/usr/src/25/Makefile:1925: modules_check] Error 1
>
Hi Andrew,

Thank you for your time and pointing out the issue. The duplicate entry
for int_pow_kunit in lib/math/Makefile and lib/math/tests/Makefile stems
from my attempt to align this patch with another[1] I had authored in a
series by David Gow that moves all lib/math/ KUnit tests to lib/math/tests/.

Since that series hasn’t landed yet, I’ll update this patch by reverting to the
current mainline approach, keeping the object file assignment in lib/math/Makefile.
This avoids assuming the approach in the David's patch series and prevents conflicts.
Once both patches are merged, I'll create a follow-up patch to align everything properly.

I apologize for the confusion and back-and-forth on this patch.
In reviewing your earlier feedback from v3 of this patch[2], I now realize
what you were referring to regarding the conflict. At the time, I failed to
fully understand the issue.

I appreciate your patience, and I’ll do my best to resolve this in a way that
minimizes further disruption.

[1] https://lore.kernel.org/all/20241202075545.3648096-2-davidgow@xxxxxxxxxx/
[2] https://lore.kernel.org/all/20241031173941.3487ccbfd7421d81d9b0cb97@xxxxxxxxxxxxxxxxxxxx/

Best,

Felipe