Re: [PATCH v2 02/19] arm64: dts: qcom: sm8350: Fix CDSP memory base and length

[Konrad Dybcio]

On 9.12.2024 12:02 PM, Krzysztof Kozlowski wrote:
> The address space in CDSP PAS (Peripheral Authentication Service)
> remoteproc node should point to the QDSP PUB address space
> (QDSP6...SS_PUB): 0x0a30_0000 with length of 0x10000.  0x9890_0000,
> value used so far, was copied from downstream DTS, is in the middle of
> RAM/DDR space and downstream DTS describes the PIL loader, which is a
> bit different interface.  Datasheet says that one of the main CDSP
> address spaces is 0x0980_0000, which is oddly similar to 0x9890_0000,
> but quite different.
> 
> Assume existing value (thus downstream DTS) is not really describing the
> intended CDSP PAS region.
> 
> Correct the base address and length, which also moves the node to
> different place to keep things sorted by unit address.  The diff looks
> big, but only the unit address and "reg" property were changed.  This
> should have no functional impact on Linux users, because PAS loader does
> not use this address space at all.
> 
> Fixes: 177fcf0aeda2 ("arm64: dts: qcom: sm8350: Add remoteprocs")
> Cc: <stable@xxxxxxxxxxxxxxx>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> ---

Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx>

Konrad