Re: [PATCH 2/3] arm64: dts: qcom: ipq9574: Enable TRNG instead PRNG
From: Konrad Dybcio
Date: Thu Dec 12 2024 - 18:55:55 EST
On 6.12.2024 8:20 AM, Md Sadre Alam wrote:
> RNG hardware versions greater than 3.0 are Truly
> Random Number Generators (TRNG). In IPQ95xx RNG
> block is TRNG. Update the corresponding compatible
> property to ensure the hardware block is registered
> with the hw_random framework, which feeds the Linux
> entropy pool.
Line wrapping should be around 72 chars, this looks funny
Please change the commit title to 'update TRNG compatible', as
'enable' implies the functionality is not present as of current.
The latter part of the last sentence is misleading, as both
compatibles do the same thing in the driver. Instead, put emphasis
on the wrong compatible being used and the patch making sure the
hardware is described properly, without functional changes.
Same for patch 3
Konrad