Re: [PATCH v4 4/6] sched_ext: Implement scx_bpf_now_ns()

[Changwoo Min]

Hello,

Thank you for the review!

On 24. 12. 11. 18:32, Peter Zijlstra wrote:
> On Mon, Dec 09, 2024 at 03:15:29PM +0900, Changwoo Min wrote:
> > +	if (!(rq->scx.flags & SCX_RQ_CLK_VALID) ||
> > +	    (rq->scx.prev_clock >= clock)) {
>
> As TJ said, it's best to consider that the clock can wrap.
I will update it as Tejun suggested.

> > +		/*
> > +		 * If the rq clock is invalid or goes backward,
> > +		 * start a new rq clock period with a fresh sched_clock_cpu().
> > +		 *
> > +		 * The cached rq clock can go backward because there is a
> > +		 * race with a timer interrupt. Suppose that a timer interrupt
> > +		 * occurred while running scx_bpf_now_ns() *after* reading the
> > +		 * rq clock and *before* comparing the if condition. The timer
> > +		 * interrupt will eventually call a BPF scheduler's ops.tick(),
> > +		 * and the BPF scheduler can call scx_bpf_now_ns(). Since the
> > +		 * scheduler core updates the rq clock before calling
> > +		 * ops.tick(), the scx_bpf_now_ns() call will get the fresh
> > +		 * clock. After handling the timer interrupt, the interrupted
> > +		 * scx_bpf_now_ns() will be resumed, so the if condition will
> > +		 * be compared. In this case, the clock, which was read before
> > +		 * the timer interrupt, will be the same as rq->scx.prev_clock.
> > +		 * When such a case is detected, start a new rq clock period
> > +		 * with a fresh sched_clock_cpu().
>
> This has a wall-of-text problem; use paragraphs?
I will improve the presentation using multiple paragraphs
and time chart.

> > +		clock = sched_clock_cpu(cpu_of(rq));
> > +		scx_rq_clock_update(rq, clock);
> Doesn't this set the VALID bit again? How is using this outside of
> RQ-lock and setting VALID a good idea?

You are right. The current implementation sets the VALID bit, so
the clock can be reused until the next update_rq_clock(). Another
approach would be not setting the VALID flag, so it gets the
fresh clock every time until next update_rq_clock(). Considering
the clock usages of the scx schedulers, both would be almost the
same in number of sched_clock_cpu() calls. But the second
approach -- not setting the VALID flag outside of rqlock -- would
be more predictable. I will double-check the difference of
sched_clock_cpu() calls, and if they are similar, I will change
it not setting the VALID flag.

Regards,
Changwoo Min