Re: [PATCH] mm: add comments to do_mmap(), mmap_region() and vm_mmap()

[Andrew Morton]

On Thu, 12 Dec 2024 11:31:52 +0000 Lorenzo Stoakes <lorenzo.stoakes@xxxxxxxxxx> wrote:

> It isn't always entirely clear to users the difference between do_mmap(),
> mmap_region() and vm_mmap(), so add comments to clarify what's going on in
> each.
> 
> This is compounded by the fact that we actually allow callers external to
> mm to invoke both do_mmap() and mmap_region() (!), the latter of which is
> really strictly speaking an internal memory mapping implementation detail.

Thanks, the world just improved.

These functions have pretty dumb names.  Patches to give them more
useful names would be small...