RE: [PATCH v2] EDAC/{i10nm,skx,skx_common}: Support UV systems

From: Zhuo, Qiuxu
Date: Fri Dec 13 2024 - 00:17:43 EST


> From: Kyle Meyer <kyle.meyer@xxxxxxx>
> Sent: Friday, December 13, 2024 9:26 AM
> To: Luck, Tony <tony.luck@xxxxxxxxx>; bp@xxxxxxxxx;
> james.morse@xxxxxxx; mchehab@xxxxxxxxxx; rric@xxxxxxxxxx; Zhuo, Qiuxu
> <qiuxu.zhuo@xxxxxxxxx>; linux-edac@xxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx
> Cc: Meyer, Kyle <kyle.meyer@xxxxxxx>
> Subject: [PATCH v2] EDAC/{i10nm,skx,skx_common}: Support UV systems
>
> The 3-bit source IDs in PCI configuration space registers, used to map devices
> to sockets, are limited to 8 unique IDs, and each ID is local to a UPI/QPI
> domain.
>
> Source IDs cannot be used to map devices to sockets on UV systems because
> they can exceed 8 sockets and have multiple UPI/QPI domains with identical,
> repeating source IDs.
>
> Use NUMA information to get package IDs instead of source IDs on UV
> systems, and use package/source IDs to name IMC information structures.
>
> Signed-off-by: Kyle Meyer <kyle.meyer@xxxxxxx>

Thanks for this patch. LGTM.
I tested it on a non-UV system and didn't observe any regressions.

Tested-by: Qiuxu Zhuo <qiuxu.zhuo@xxxxxxxxx>
Reviewed-by: Qiuxu Zhuo <qiuxu.zhuo@xxxxxxxxx>

Thanks!
-Qiuxu