Re: [PATCH] staging: gpib: Replace semaphore with completion for one-time signaling

[Dan Carpenter]

On Thu, Dec 12, 2024 at 09:51:04PM +0530, eisantosh95@xxxxxxxxx wrote:
> From: Santosh Mahto <eisantosh95@xxxxxxxxx>
> 
> Replaced 'down_interruptible()' and 'up()' calls
> with 'wait_for_completion_interruptible()' and
> 'complete()' respectively. The completion API
> simplifies the code and adheres to kernel best
> practices for synchronization primitive
> 
> Signed-off-by: Santosh Mahto <eisantosh95@xxxxxxxxx>

Looks okay to me.

Reviewed-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>

regards,
dan carpenter