Re: [PATCH v3 1/6] dt-bindings: interrupt-controller: Refine size/interrupt-cell usage.

From: Krzysztof Kozlowski
Date: Fri Dec 13 2024 - 04:11:17 EST


On Thu, Dec 12, 2024 at 11:52:31PM +0800, Kevin Chen wrote:
> 1. Because size-cells is no need to use 2, modify to 1 for use.
> 2. Add minItems to 1 for interrupts for intc1.
> 3. Add 1 interrupt of intc1 example into yaml file.
> 4. Add intc1 sub-module of uart12 as example using the intc0 and intc1.
> ---
> .../aspeed,ast2700-intc.yaml | 60 +++++++++++++++----
> 1 file changed, 47 insertions(+), 13 deletions(-)
>

As with all your patches, repeating since v1 the same comment, so one
more last time:

Please run scripts/checkpatch.pl and fix reported warnings. Then please
run 'scripts/checkpatch.pl --strict' and (probably) fix more warnings.
Some warnings can be ignored, especially from --strict run, but the code
here looks like it needs a fix. Feel free to get in touch if the warning
is not clear.

Best regards,
Krzysztof