Re: [PATCH] Bluetooth: btmtk: add quirk to support HCI_QUIRK_SIMULTANEOUS_DISCOVERY

From: Paul Menzel
Date: Fri Dec 13 2024 - 04:46:39 EST


Dear Chris,


Thank you for your patch.


Am 13.12.24 um 10:41 schrieb Chris Lu:
Add quirk to support HCI_QUIRK_SIMULTANEOUS_DISCOVERY feature for MT79xx
series chipset.

It’d be great if you elaborated. What is the problem. Why is a quirk needed? Is a firmware update going to fix it?

Signed-off-by: Chris Lu <chris.lu@xxxxxxxxxxxx>
---
drivers/bluetooth/btmtk.c | 3 +++
1 file changed, 3 insertions(+)

diff --git a/drivers/bluetooth/btmtk.c b/drivers/bluetooth/btmtk.c
index 8a3f7c3fcfec..562d6ecf0b71 100644
--- a/drivers/bluetooth/btmtk.c
+++ b/drivers/bluetooth/btmtk.c
@@ -1367,6 +1367,9 @@ int btmtk_usb_setup(struct hci_dev *hdev)
return err;
}
+ /* Apply common HCI quirks for MediaTek chipset */
+ set_bit(HCI_QUIRK_SIMULTANEOUS_DISCOVERY, &hdev->quirks);
+

The commit message only talks about MT79xx series chipset. The comment talks about all MediaTek chipsets.

hci_set_msft_opcode(hdev, 0xFD30);
hci_set_aosp_capable(hdev);


Kind regards,

Paul