Re: [PATCH v2] PCI: Avoid putting some root ports into D3 on some Ryzen chips

From: Richard Hughes
Date: Fri Dec 13 2024 - 05:05:50 EST


On Thursday, 12 December 2024 at 19:01, Mario Limonciello <mario.limonciello@xxxxxxx> wrote:
> > > > > Sadly fwupd/LVFS does not support executing arbitrary efi binaries/
> > > > > nsh scripts which still is the main form ODMs provide bios updates.

Of course fwupd can't do this; it would be a huge security hole as the nsh script isn't signed.

> It sounds like some bugs in the implementation of the capsule handler
> for this system.

I've seen this with AmiFlash + BIOS.ROM, but never from a capsule. I'm pretty sure Aptio builder is more than capable of constructing a capsule file with the correct DMI data.

> It's not an Insyde problem. I use Insyde capsules regularly myself from
> fwupd. I also know several other OEMs that ship capsules to LVFS that
> use Insyde.

100% agreed; Insyde firmware makes up more than 20% of the updates on the LVFS now.

Richard.