Re: [PATCH v2] regulator:s5m8767: Fully convert to GPIO descriptors

From: Song Chen
Date: Fri Dec 13 2024 - 05:25:39 EST


Hi Bart,

在 2024/12/12 18:29, Bartosz Golaszewski 写道:
On Thu, Dec 12, 2024 at 6:55 AM Song Chen <chensong_2000@xxxxxx> wrote:

Or we can use devm_gpiod_get_array, it's pretty much equivalent effect
in s5m8767 even without fwnode specified.


Can you use it though? I was thinking you need the fwnode variant
because it's the child (regulator) node of the device?

If you can, that would be great.

Bart


yes, i believe so, eventually both devm_gpiod_get_array and devm_fwnode_gpiod_get_index use of_fwnode_handle(iodev->dev->of_node) in this case.

But, i think it's a good idea to introduce a helper to get gpio descriptor array with fwnode, i have made a patch, would appreciate it if you can help me have a look.

Best regards,

Song