Re: [PATCH v6 5/5] arm64: dts: qcom: Update IPQ9574 xo_board_clk to use fixed factor clock

[Jie Luo]

On 12/13/2024 2:33 AM, Konrad Dybcio wrote:
> On 7.11.2024 10:50 AM, Luo Jie wrote:
> > xo_board_clk is fixed to 24 MHZ, which is routed from WiFi output clock
> > 48 MHZ (also being the reference clock of CMN PLL) divided 2 by analog
> > block routing channel.
> >
> > Signed-off-by: Luo Jie <quic_luoj@xxxxxxxxxxx>
> > ---
> >   arch/arm64/boot/dts/qcom/ipq9574-rdp-common.dtsi | 7 ++++++-
> >   arch/arm64/boot/dts/qcom/ipq9574.dtsi            | 3 ++-
> >   2 files changed, 8 insertions(+), 2 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/ipq9574-rdp-common.dtsi b/arch/arm64/boot/dts/qcom/ipq9574-rdp-common.dtsi
> > index 78f6a2e053d5..9a8692377176 100644
> > --- a/arch/arm64/boot/dts/qcom/ipq9574-rdp-common.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/ipq9574-rdp-common.dtsi
> > @@ -174,8 +174,13 @@ &ref_48mhz_clk {
> >   	clock-mult = <1>;
> >   };
> >   
> > +/*
> > + * The frequency of xo_board_clk is fixed to 24 MHZ, which is routed
> > + * from WiFi output clock 48 MHZ divided by 2.
> > + */
> >   &xo_board_clk {
> > -	clock-frequency = <24000000>;
> > +	clock-div = <2>;
> > +	clock-mult = <1>;
> >   };
> >   
> >   &xo_clk {
> > diff --git a/arch/arm64/boot/dts/qcom/ipq9574.dtsi b/arch/arm64/boot/dts/qcom/ipq9574.dtsi
> > index 8246a00a3e3e..25aed33e9358 100644
> > --- a/arch/arm64/boot/dts/qcom/ipq9574.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/ipq9574.dtsi
> > @@ -32,7 +32,8 @@ sleep_clk: sleep-clk {
> >   		};
> >   
> >   		xo_board_clk: xo-board-clk {
> > -			compatible = "fixed-clock";
> > +			compatible = "fixed-factor-clock";
> > +			clocks = <&ref_48mhz_clk>;
>
> This must be squashed with the previous patch, you can't introduce
> code and replace it immediately afterwards.
>
> Konrad

Ok, I will update the patch series with this patch dislodged, and push
this single patch in next update. Thanks.