Re: [PATCH v2 3/3] dts: arm64: mediatek: mt8195: Remove MT8183 compatible for OVL

[AngeloGioacchino Del Regno]

Il 13/12/24 11:27, Pin-yen Lin ha scritto:
> Hi Jason,
>
> On Fri, Dec 13, 2024 at 5:50 PM Jason-JH.Lin <jason-jh.lin@xxxxxxxxxxxx> wrote:
> > The OVL hardware capabilities have changed starting from MT8195,
> > making the MT8183 compatible no longer applicable.
> > Therefore, it is necessary to remove the MT8183 compatible for OVL.
>
> Similar to patch 2/3, we need a:
>
> Fixes: b852ee68fd72 ("arm64: dts: mt8195: Add display node for vdosys0")

No, we don't, for reasons that are similar to the ones that I explained in the
MT8188 commit.

Besides, this one was already featureful before this commit, so really this is
not worth backporting at all.

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx>

> > Signed-off-by: Jason-JH.Lin <jason-jh.lin@xxxxxxxxxxxx>
> > ---
> >   arch/arm64/boot/dts/mediatek/mt8195.dtsi | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm64/boot/dts/mediatek/mt8195.dtsi b/arch/arm64/boot/dts/mediatek/mt8195.dtsi
> > index ade685ed2190..137ee8929e01 100644
> > --- a/arch/arm64/boot/dts/mediatek/mt8195.dtsi
> > +++ b/arch/arm64/boot/dts/mediatek/mt8195.dtsi
> > @@ -3138,7 +3138,7 @@ larb20: larb@1b010000 {
> >                  };
> >
> >                  ovl0: ovl@1c000000 {
> > -                       compatible = "mediatek,mt8195-disp-ovl", "mediatek,mt8183-disp-ovl";
> > +                       compatible = "mediatek,mt8195-disp-ovl";
> >                          reg = <0 0x1c000000 0 0x1000>;
> >                          interrupts = <GIC_SPI 636 IRQ_TYPE_LEVEL_HIGH 0>;
> >                          power-domains = <&spm MT8195_POWER_DOMAIN_VDOSYS0>;
> > --
> > 2.43.0
>
> Regards,
> Pin-yen