Re: [PATCH 2/2] arm64: dts: qcom: Enable DisplayPort on QCS615 RIDE platform

[Xiangxu Yin]

On 12/10/2024 6:48 PM, Dmitry Baryshkov wrote:
> On Tue, Dec 10, 2024 at 05:11:06PM +0800, Xiangxu Yin wrote:
>> Enable the DisplayPort node, config related regulator, lane mapping,
>> hpd-gpios on the Qualcomm QCS615 RIDE platform.
>>
>> Signed-off-by: Xiangxu Yin <quic_xiangxuy@xxxxxxxxxxx>
>> ---
>>  arch/arm64/boot/dts/qcom/qcs615-ride.dts | 30 ++++++++++++++++++++++++++++++
>>  1 file changed, 30 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/qcs615-ride.dts b/arch/arm64/boot/dts/qcom/qcs615-ride.dts
>> index 694719a09ac46bfa2fe34f1883c0970b9d0902be..0ac543577ec1850d6e4f19ff1d64252b00fffae3 100644
>> --- a/arch/arm64/boot/dts/qcom/qcs615-ride.dts
>> +++ b/arch/arm64/boot/dts/qcom/qcs615-ride.dts
>> @@ -44,6 +44,20 @@ dp_connector_out: endpoint {
>>  			};
>>  		};
>>  	};
> 
> You mentioned v3 of the display support series. However v3 doesn't
> contain dp_connector_out label.
> 
My typo, this patch based v4 of display support, but it not properly updated to the cover.
Will update cover info in next patch.
>> +
>> +	dp2-connector {
>> +		compatible = "dp-connector";
>> +		label = "DP2";
>> +		type = "mini";
>> +
>> +		hpd-gpios = <&ioexp 8 GPIO_ACTIVE_HIGH>;
>> +
>> +		port {
>> +			dp2_connector_in: endpoint {
>> +				remote-endpoint = <&mdss_dp0_out>;
>> +			};
>> +		};
>> +	};
>>  };
>>  
>>  &apps_rsc {
>> @@ -291,6 +305,22 @@ &mdss_dsi0_phy {
>>  	status = "okay";
>>  };
>>  
>> +&mdss_dp0 {
>> +	status = "okay";
>> +};
>> +
>> +&mdss_dp0_out {
>> +	data-lanes = <3 2 0 1>;
> 
> This hasn't been agreed upon yet. Please abstain from using the
> configuration bits that are still in discussion.
> 
Ok, I'll update next dt patch after the lane mapping discussion.
>> +	link-frequencies = /bits/ 64 <1620000000 2700000000 5400000000>;
>> +	remote-endpoint = <&dp2_connector_in>;
>> +};
>> +
>> +&mdss_dp_phy {
>> +	vdda-phy-supply = <&vreg_l11a>;
>> +	vdda-pll-supply = <&vreg_l5a>;
>> +	status = "okay";
>> +};
>> +
>>  &qupv3_id_0 {
>>  	status = "okay";
>>  };
>>
>> -- 
>> 2.34.1
>>
>