Re: [PATCH 1/2] dt-bindings: power: supply: gpio-charger: add support for default charge current limit

[Krzysztof Kozlowski]

On Wed, Dec 11, 2024 at 08:29:09AM +0100, Dimitri Fedrau wrote:
> Add binding for default charge current limit.

Why?

> 
> Signed-off-by: Dimitri Fedrau <dimitri.fedrau@xxxxxxxxxxxx>
> ---
>  Documentation/devicetree/bindings/power/supply/gpio-charger.yaml | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/power/supply/gpio-charger.yaml b/Documentation/devicetree/bindings/power/supply/gpio-charger.yaml
> index 89f8e2bcb2d7836c6a4308aff51721bd83fa3ba1..545fdd7133daf67b5bc238c5af26d0cbd8b44eae 100644
> --- a/Documentation/devicetree/bindings/power/supply/gpio-charger.yaml
> +++ b/Documentation/devicetree/bindings/power/supply/gpio-charger.yaml
> @@ -58,6 +58,10 @@ properties:
>              charge-current-limit-gpios property. Bit 1 second to last
>              GPIO and so on.
>  
> +  charge-current-limit-default:

Use standard property suffixes - see other bindings how they define
charge current.
git grep charge -- Documentation/devicetree/bindings/power/supply/

But what I don't get is why GPIO chager needs it, since this is
non-configurable for GPIO charger.

You have entire commit msg or property description to explain such
things.

Best regards,
Krzysztof