Re: [PATCH v9 4/7] arm64: dts: qcom: ipq5332: Add tsens node
From: Konrad Dybcio
Date: Fri Dec 13 2024 - 07:59:53 EST
On 25.11.2024 6:07 AM, Manikanta Mylavarapu wrote:
> From: Praveenkumar I <quic_ipkumar@xxxxxxxxxxx>
>
> IPQ5332 has tsens v2.3.3 peripheral. This patch adds the tsens
> node with nvmem cells for calibration data.
>
> Signed-off-by: Praveenkumar I <quic_ipkumar@xxxxxxxxxxx>
> Signed-off-by: Manikanta Mylavarapu <quic_mmanikan@xxxxxxxxxxx>
> ---
[...]
>
> + tsens: thermal-sensor@4a9000 {
> + compatible = "qcom,ipq5332-tsens";
> + reg = <0x004a9000 0x1000>,
> + <0x004a8000 0x1000>;
> + nvmem-cells = <&tsens_mode>,
> + <&tsens_base0>,
> + <&tsens_base1>,
> + <&tsens_sens11_off>,
> + <&tsens_sens12_off>,
> + <&tsens_sens13_off>,
> + <&tsens_sens14_off>,
> + <&tsens_sens15_off>;
> + nvmem-cell-names = "mode",
> + "base0",
> + "base1",
> + "tsens_sens11_off",
> + "tsens_sens12_off",
> + "tsens_sens13_off",
> + "tsens_sens14_off",
> + "tsens_sens15_off";
> + interrupts = <GIC_SPI 320 IRQ_TYPE_LEVEL_HIGH>;
> + interrupt-names = "combined";
Please move interrupts properties above nvmem
with that:
Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx>
Konrad