Re: [PATCH v2 2/4] dt-bindings: display/msm/gmu: Document RGMU

From: Akhil P Oommen
Date: Fri Dec 13 2024 - 08:37:48 EST


On 12/13/2024 4:23 PM, Konrad Dybcio wrote:
> On 13.12.2024 11:35 AM, Akhil P Oommen wrote:
>> RGMU a.k.a Reduced Graphics Management Unit is a small state machine
>> with the sole purpose of providing IFPC support. Compared to GMU, it
>> doesn't manage GPU clock, voltage scaling, bw voting or any other
>> functionalities. All it does is detect an idle GPU and toggle the
>> GDSC switch. So it doesn't require iommu & opp table.
>>
>> Signed-off-by: Akhil P Oommen <quic_akhilpo@xxxxxxxxxxx>
>> ---
>
> The bindings file exists so that people that are not in the know, can
> reference it and learn about the hardware. Please spell out IFPC, as
> that's a non-obvious, hw-specific acronym.
>
> Otherwise looks ok

Ah right. Krzysztof schooled me that a while ago.
Will update.

-Akhil.

>
> Konrad