Re: [PATCH v3 13/23] arm64: dts: qcom: x1e80100: Fix ADSP memory base and length

[Johan Hovold]

On Fri, Dec 13, 2024 at 03:54:02PM +0100, Krzysztof Kozlowski wrote:
> The address space in ADSP PAS (Peripheral Authentication Service)
> remoteproc node should point to the QDSP PUB address space
> (QDSP6...SS_PUB): 0x0680_0000 with length of 0x10000.
> 
> 0x3000_0000, value used so far, is the main region of CDSP and was
> simply copied from other/older DTS.
> 
> Correct the base address and length, which also moves the node to
> different place to keep things sorted by unit address.  The diff looks
> big, but only the unit address and "reg" property were changed.  This
> should have no functional impact on Linux users, because PAS loader does
> not use this address space at all.
> 
> Fixes: 5f2a9cd4b104 ("arm64: dts: qcom: x1e80100: Add ADSP/CDSP remoteproc nodes")
> Cc: stable@xxxxxxxxxxxxxxx

Why bother with backporting any of these when there is no functional
impact?

This does not seem to meet the stable kernel backport criteria and will
just result in a lot of noise. (I'm sure autosel will try to pull them
in, but that's a different discussion.)

> Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> ---
> 
> Changes in v2:
> 1. Commit msg corrections, second paragraph (Johan)

Looks good to me otherwise:

Reviewed-by: Johan Hovold <johan+linaro@xxxxxxxxxx>