Re: [PATCH V2 8/8] accel/amdxdna: Add include interrupt.h to amdxdna_mailbox.c

[Jeffrey Hugo]

On 12/6/2024 3:00 PM, Lizhi Hou wrote:
> For amdxdna_mailbox.c, linux/interrupt.h is indirectly included by
> trace/events/amdxdna.h. So if TRACING is disabled, driver compiling will
> fail.
>
> Fixes: b87f920b9344 ("accel/amdxdna: Support hardware mailbox")
> Reported-by: Mike Lothian <mike@xxxxxxxxxxxxxx>
> Closes: https://lore.kernel.org/dri-devel/CAHbf0-E+Z2O7rW-x+-EKNQ-nLbf=_ohaNzXxE7WD2cj9kFJERQ@xxxxxxxxxxxxxx/
> Signed-off-by: Mike Lothian <mike@xxxxxxxxxxxxxx>
> Signed-off-by: Lizhi Hou <lizhi.hou@xxxxxxx>

Slight problem with the SOB chain which prevents me from applying this.

Mike comes first, which indicates he authored this patch.  Then you, 
which says you took Mike's patch and are moving it forward.  However, 
since you sent it and it doesn't have "From: Mike", you get listed as 
author.

Either Mike needs to be the listed author, or a Co-developed-by tag for 
Mike needs to be listed immediately before his SOB.

With either of those:

Reviewed-by: Jeffrey Hugo <quic_jhugo@xxxxxxxxxxx>