Re: [PATCH V2 3/8] accel/amdxdna: Add RyzenAI-npu6 support

[Lizhi Hou]

On 12/13/24 08:37, Jeffrey Hugo wrote:
> On 12/6/2024 2:59 PM, Lizhi Hou wrote:
> > Add NPU6 registers and other private configurations.
> >
> > Co-developed-by: Xiaoming Ren <xiaoming.ren@xxxxxxx>
> > Signed-off-by: Xiaoming Ren <xiaoming.ren@xxxxxxx>
> > Signed-off-by: Lizhi Hou <lizhi.hou@xxxxxxx>
> > ---
> >   drivers/accel/amdxdna/Makefile    |   3 +-
> >   drivers/accel/amdxdna/npu6_regs.c | 121 ++++++++++++++++++++++++++++++
>
> This looks like dead code to me. I would expect somewhere else in the 
> driver, dev_npu6_info would be used, but that is not the case.  What 
> am I missing?

You are correct. I miss merged one line to the patch in amdxdna_idx[]..  
Thanks a lot.


Lizhi

> -Jeff