Re: [PATCH V2 5/8] accel/amdxdna: Add query firmware version

[Jeffrey Hugo]

On 12/6/2024 2:59 PM, Lizhi Hou wrote:
> Enhance GET_INFO ioctl to support retrieving firmware version.
>
> Signed-off-by: Lizhi Hou <lizhi.hou@xxxxxxx>

Reviewed-by: Jeffrey Hugo <quic_jhugo@xxxxxxxxxxx>

Warning below through.

>   enum amdxdna_drm_get_param {
>   	DRM_AMDXDNA_QUERY_AIE_STATUS,
>   	DRM_AMDXDNA_QUERY_AIE_METADATA,
> @@ -382,7 +396,7 @@ enum amdxdna_drm_get_param {
>   	DRM_AMDXDNA_QUERY_CLOCK_METADATA,
>   	DRM_AMDXDNA_QUERY_SENSORS,
>   	DRM_AMDXDNA_QUERY_HW_CONTEXTS,
> -	DRM_AMDXDNA_NUM_GET_PARAM,
> +	DRM_AMDXDNA_QUERY_FIRMWARE_VERSION = 8,

This would normally be considered breaking the uAPI, but since this 
driver is not yet in a released kernel, this is allowed. Keep this in 
mind for the future (can add things, but not remove them).