Re: [PATCH v6] staging: gpib: Fix i386 build issue

[Guenter Roeck]

On 12/13/24 02:53, Dave Penkler wrote:
> On Wed, Dec 11, 2024 at 11:42:36AM -0800, Guenter Roeck wrote:
> > On 12/11/24 08:44, Dave Penkler wrote:
> > > These drivers cast resource_type_t to void * causing the build to fail.
> > >
> > > With a 32 bit build and PHYS_ADDR_T_64BIT enabled the resource_size_t
> > > type is a 64bit unsigned int which cannot be cast to a 32 bit pointer.
> > >
> > > Disable these drivers if not 64BIT and PHYS_ADDR_T_64BIT are configured.
> > >
> > > Link: https://lore.kernel.org/linux-staging/2c6c7e9d-ca10-47a9-82a7-a2e26b1f51ef@xxxxxxxxxxxx/
> > > Reported-by: Guenter Roeck <linux@xxxxxxxxxxxx>
> > > Closes: https://lore.kernel.org/all/f10e976e-7a04-4454-b38d-39cd18f142da@xxxxxxxxxxxx/
> > > Fixes: e9dc69956d4d ("staging: gpib: Add Computer Boards GPIB driver")
> > > Fixes: e1339245eba3 ("staging: gpib: Add Computer Equipment Corporation GPIB driver")
> > > Fixes: bb1bd92fa0f2 ("staging: gpib: Add ines GPIB driver")
> > > Fixes: 0cd5b05551e0 ("staging: gpib: Add TNT4882 chip based GPIB driver")
> > > Signed-off-by: Dave Penkler <dpenkler@xxxxxxxxx>
> >
> > Tested-by: Guenter Roeck <linux@xxxxxxxxxxxx>
> >
> > Guenter
> Hi Guenter,
> These nice patches from Arnd fix the i386 build issue without having applied
> my v6 patch:
> Link: https://lore.kernel.org/linux-staging/20241213064959.1045243-1-arnd@xxxxxxxxxx/
>
> I tested only
> make ARCH=i386 allmodconfig
> make ARCH=i386 M=drivers/staging/gpib
>
> -Dave

I don't care how this is fixed. What I do care about it that we are close to -rc3, and my
test builds still fail.

Build results:
	total: 161 pass: 155 fail: 6
Failed builds:
	csky:allmodconfig
	i386:allyesconfig
	i386:allmodconfig
	openrisc:allmodconfig
	s390:allmodconfig
	xtensa:allmodconfig

all because of GPIB problems. Given that this is a staging driver, I am inclined to just
hard-disable GPIB completely in my test coverage. I'll do that after -rc3 is out.

Guenter