Re: [PATCH v6 2/2] power/supply: Add support for ltc4162-f/s and ltc4015

From: Christophe JAILLET
Date: Fri Dec 13 2024 - 13:32:13 EST


Le 13/12/2024 à 03:37, Kim Seer Paller a écrit :
LTC4162-L 35V/3.2A Multi-Cell Lithium-Ion Step-Down Battery Charger
LTC4162-F 35V/3.2A Multi-Cell LiFePO4 Step-Down Battery Charger
LTC4162-S 35V/3.2A Lead-Acid Step-Down Battery Charger
LTC4015 35V/3.2A Multichemistry Buck Battery Charger Controller

...

+static int ltc4015_get_vcharge(struct ltc4162l_info *info,
+ unsigned int reg,
+ union power_supply_propval *val)
{
- u8 cell_count = ltc4162l_get_cell_count(info);
+ unsigned int regval, chem_type;
+ int ret;
+ u32 voltage;
+
+ ret = regmap_read(info->regmap, reg, &regval);
+ if (ret)
+ return ret;
- if (!cell_count)
- return -EBUSY; /* Not available yet, try again later */
+ regval &= BIT(6) - 1; /* Only the lower 5 bits */

Nitpick, should there be a v7:
Would using GENMASK(5, 0) be clearer and self-explanatory?

+
+ /*
+ * charge voltage setting can be computed from:
+ * cell_count × (vcharge_setting × a + b)
+ * where vcharge_setting ranges from 0 to c (d).
...

CJ