Re: [PATCH v13 0/2] rust: xarray: Add a minimal abstraction for XArray

From: Miguel Ojeda
Date: Fri Dec 13 2024 - 16:31:55 EST


On Fri, Dec 13, 2024 at 9:02 PM Tamir Duberstein <tamird@xxxxxxxxx> wrote:
>
> Changes in v13:
> - Replace `bool::then` with `if`. (Miguel Ojeda)
> - Replace `match` with `let` + `if`. (Miguel Ojeda)

Personally, I would also use the early return style in both of these,
like in C. I think you may also omit the parenthesis in the first one.

(No need for a new version just for this)

Thanks!

Cheers,
Miguel