Re: [PATCH] mm: fix outdated incorrect code comments for handle_mm_fault()

[Jinliang Zheng]

On Fri, 13 Dec 2024 10:24:00 -0500, Liam R. Howlett wrote:
> * Jinliang Zheng <alexjlzheng@xxxxxxxxx> [241212 22:18]:
> > Signed-off-by: Jinliang Zheng <alexjlzheng@xxxxxxxxxxx>
> > ---
> >  mm/memory.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/mm/memory.c b/mm/memory.c
> > index d9af83dd86bb..d7342a726845 100644
> > --- a/mm/memory.c
> > +++ b/mm/memory.c
> > @@ -6159,7 +6159,8 @@ static vm_fault_t sanitize_fault_flags(struct vm_area_struct *vma,
> >  }
> >  
> >  /*
> > - * By the time we get here, we already hold the mm semaphore
> > + * By the time we get here, we already hold either the VMA lock or the
> > + * mmap_Lock (FAULT_FLAG_VMA_LOCK tells you which).
>            ^ lower case here please, otherwise looking for mmap_lock
> 	   could fail. ie: grep mmap_lock..

Thank you, I will send a v2 patch.

Jinliang Zheng :)

> >   *
> >   * The mmap_lock may have been released depending on flags and our
> >   * return value.  See filemap_fault() and __folio_lock_or_retry().
> > -- 
> > 2.41.1
> > 
> >