Re: [PATCH] dt-bindings: iio: dac: ad5791: ldac gpio is active low

From: David Lechner
Date: Sat Dec 14 2024 - 15:24:21 EST


On 11/6/24 4:38 AM, ahaslam@xxxxxxxxxxxx wrote:
> From: Axel Haslam <ahaslam@xxxxxxxxxxxx>
>
> On the example, the ldac gpio is flagged as active high, when in reality
> its an active low gpio. Fix the example by using the active low flag for
> the ldac gpio.
>
> Fixes: baaa92d284d5 ("dt-bindings: iio: dac: ad5791: Add optional reset, clr and ldac gpios")
> Signed-off-by: Axel Haslam <ahaslam@xxxxxxxxxxxx>
> ---
> Documentation/devicetree/bindings/iio/dac/adi,ad5791.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/iio/dac/adi,ad5791.yaml b/Documentation/devicetree/bindings/iio/dac/adi,ad5791.yaml
> index 79cb4b78a88a..2bd89e0aa46b 100644
> --- a/Documentation/devicetree/bindings/iio/dac/adi,ad5791.yaml
> +++ b/Documentation/devicetree/bindings/iio/dac/adi,ad5791.yaml
> @@ -91,7 +91,7 @@ examples:
> vrefn-supply = <&dac_vrefn>;
> reset-gpios = <&gpio_bd 16 GPIO_ACTIVE_LOW>;
> clear-gpios = <&gpio_bd 17 GPIO_ACTIVE_LOW>;
> - ldac-gpios = <&gpio_bd 18 GPIO_ACTIVE_HIGH>;
> + ldac-gpios = <&gpio_bd 18 GPIO_ACTIVE_LOW>;
> };
> };
> ...

Hi Jonathan, any reason this one didn't get picked up yet?