RE: [RFC net-next v02 1/3] net: hinic3: module initialization and tx/rx logic
From: Gur Stavi
Date: Sun Dec 15 2024 - 04:00:16 EST
> Is the PPF selected dynamically by the driver? By firmware on the
> NIC?
Selected dynamically by PF driver but initial submission only contains
VF logic.
> > + # Fields of HW and management structures are little endian and will
> not
> > + # be explicitly converted
>
> I guess this comment is here to explain the !CPU_BIG_ENDIAN below?
> That's quite an unusual dependency.
>
Yes. Otherwise the code will be swamped with cpu_to_le and le_to_cpu.
Microsoft and Amazon drivers have it as well. I wonder if all other
drivers were tested on big endian host.
Dependency on CPU_LITTLE_ENDIAN would be nicer but unfortunately x86
arch does not define it.
> > + depends on 64BIT && !CPU_BIG_ENDIAN
>
Other comments were addressed in files for next submission.