Re: [PATCH] usb: gadget: f_fs: remove unused values and add immediate returns

From: Karol P
Date: Sun Dec 15 2024 - 06:41:30 EST


On Thu, 7 Nov 2024 at 06:15, Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
>
> On Wed, Nov 06, 2024 at 07:30:32PM +0100, Karol Przybylski wrote:
> > In case of faulty copy_from_user call inside ffs_epfile_ioctl, error code is
> > saved in a variable. However, this variable is later overwritten in every possible
> > path, which overshadows initial assignment.
> >
> > This patch fixes it by returning the error code immediately and exiting the function.
> >
> > Error discovered in coverity scan - CID 1583682
> >
> > Signed-off-by: Karol Przybylski <karprzy7@xxxxxxxxx>
> > ---
> > drivers/usb/gadget/function/f_fs.c | 9 +++------
> > 1 file changed, 3 insertions(+), 6 deletions(-)
>
> What commit id does this fix?

7b07a2a7ca02a, usb: gadget: functionfs: Add DMABUF import interface

>
> How was this change tested?

I compiled the kernel and ran it on my machine.
Are there other ways to reliably test such change?

>
> thanks,
>
> greg k-h