Re: [PATCH] platform/x86: samsung-galaxybook: Add samsung-galaxybook driver

[Randy Dunlap]

On 12/15/24 8:09 AM, Joshua Grisham wrote:
> Den mån 9 dec. 2024 kl 18:04 skrev Randy Dunlap <rdunlap@xxxxxxxxxxxxx>:
>>
>> Also needs <linux/sysfs.h>.
>> Maybe <linux/printk.h>.
>> Maybe <linux/err.h>.
>>
>> --
>> ~Randy
>>
> 
> Also done in v2 of the patch, thanks Randy! (though no printk.h
> anymore as I removed all pr_* functions.. maybe I should explicitly
> add <linux/dev_printk.h> though? or is it good enough to get it via
> platform_device.h <= device.h <= dev_printk.h  ?)
> 
> Joshua

from Documentation/process/submit-checklist.rst:

1) If you use a facility then #include the file that defines/declares
   that facility.  Don't depend on other header files pulling in ones
   that you use.


-- 
~Randy