Re: [PATCH net-next 3/7] mptcp: add mptcp_userspace_pm_get_sock helper

From: Jakub Kicinski
Date: Sun Dec 15 2024 - 17:32:27 EST


On Fri, 13 Dec 2024 20:52:54 +0100 Matthieu Baerts (NGI0) wrote:
> struct nlattr *token = info->attrs[MPTCP_PM_ATTR_TOKEN];
> + struct mptcp_sock *msk;
> +
> + if (!token) {
> + GENL_SET_ERR_MSG(info, "missing required token");
> + return NULL;
> + }

Ideally GENL_REQ_ATTR_CHECK() would be used in such cases.