Re: [PATCH] staging: gpib: Workaround for ppc build failure

[Guenter Roeck]

On Wed, Dec 04, 2024 at 02:47:36PM +0100, Dave Penkler wrote:
> Make GPIB_FMH depend on !PPC
> 
> Reported_by: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx>
> Link: https://lore.kernel.org/all/20241015165538.634707e5@xxxxxxxxxxxxxxxx/
> 
> Signed-off-by: Dave Penkler <dpenkler@xxxxxxxxx>

This patch just exposes other build failures, for example
i386:allyesconfig or x86_64:allyesconfig.

Error log:
x86_64-linux-ld: vmlinux.o: in function `fmh_gpib_t1_delay':
fmh_gpib.c:(.text+0xfd49dbd): undefined reference to `nec7210_t1_delay'

There are many more missing functions. FWIW, I don't know how this is
supposed to work in the first place, since pretty much all gpib Makefiles
say

obj-m += <object file>

meaning they won't be built with allyesconfig. fmh_gpib is the only
exception with

obj-$(CONFIG_GPIB_FMH) += fmh_gpib.o

which means it _will_ be built with allyesconfig. So it is not surprising
that it fails to link allyesconfig builds. Actually, it will fail all builds
with CONFIG_GPIB_FMH=y.

Guenter