Re: [PATCH next 1/2] octeontx2-pf: fix netdev memory leak in rvu_rep_create()

[Przemek Kitszel]

On 12/16/24 08:05, Harshit Mogalapalli wrote:
> When rvu_rep_devlink_port_register() fails, free_netdev(ndev) for this
> incomplete iteration before going to "exit:" label.
>
> Fixes: 3937b7308d4f ("octeontx2-pf: Create representor netdev")

I would say that you are fixing:
Fixes: 9ed0343f561e ("octeontx2-pf: Add devlink port support")

this is also a -net material

code is fine otherwise, so:
Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@xxxxxxxxx>

> Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@xxxxxxxxxx>
> ---
> This is found by Smatch, based on static analysis, only compile tested.
> ---
>   drivers/net/ethernet/marvell/octeontx2/nic/rep.c | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/rep.c b/drivers/net/ethernet/marvell/octeontx2/nic/rep.c
> index 232b10740c13..9e3fcbae5dee 100644
> --- a/drivers/net/ethernet/marvell/octeontx2/nic/rep.c
> +++ b/drivers/net/ethernet/marvell/octeontx2/nic/rep.c
> @@ -680,8 +680,10 @@ int rvu_rep_create(struct otx2_nic *priv, struct netlink_ext_ack *extack)
>   		ndev->features |= ndev->hw_features;
>   		eth_hw_addr_random(ndev);
>   		err = rvu_rep_devlink_port_register(rep);
> -		if (err)
> +		if (err) {
> +			free_netdev(ndev);
>   			goto exit;
> +		}
>   
>   		SET_NETDEV_DEVLINK_PORT(ndev, &rep->dl_port);
>   		err = register_netdev(ndev);