Re: [PATCH v5 07/20] x86/kexec: Invoke copy of relocate_kernel() instead of the original

From: David Woodhouse
Date: Mon Dec 16 2024 - 03:14:14 EST


On Sun, 2024-12-15 at 22:49 -0700, Nathan Chancellor wrote:
> On Sun, Dec 15, 2024 at 10:09:57AM +0000, David Woodhouse wrote:
> > On Sat, 2024-12-14 at 16:08 -0700, Nathan Chancellor wrote:
> > >
> > > I guess this seems somewhat unavoidable because control_page is just a
> > > 'void *', perhaps machine_kexec() should just be marked as __nocfi? This
> > > diff resolves that issue for me.
> >
> > The patch below seems to work too. I already wanted to deal with the
>
> Can confirm, thanks for the quick fix. With your fix for the first issue
> I reported, the fix I sent for LTO, and this patch below, I can kexec on
> a CFI and LTO enabled kernel without any issues.
>

Thank you for testing. Which is the LTO one? Is it in my tree yet or
have I missed it?
https://git.infradead.org/?p=users/dwmw2/linux.git;a=shortlog;h=refs/heads/kexec-debug

(The fix we're discussing here isn't there yet; it still needs
polishing)

Attachment: smime.p7s
Description: S/MIME cryptographic signature