Re: [PATCH 3/5] soc: renesas: rz-sysc: Add support for RZ/G3E family

[Geert Uytterhoeven]

Hi John,

On Sat, Dec 14, 2024 at 5:36 AM John Madieu
<john.madieu.xa@xxxxxxxxxxxxxx> wrote:
> > From: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> > On Fri, Dec 6, 2024 at 10:26 PM John Madieu
> > <john.madieu.xa@xxxxxxxxxxxxxx> wrote:
> > > Add SoC detection support for RZ/G3E SoC. Also add support for
> > > detecting the number of cores and ETHOS-U55 NPU and also detect PLL
> > > mismatch for SW settings other than 1.7GHz.
> > >
> > > Signed-off-by: John Madieu <john.madieu.xa@xxxxxxxxxxxxxx>

> > > --- a/drivers/soc/renesas/rz-sysc.h
> > > +++ b/drivers/soc/renesas/rz-sysc.h
> > > @@ -42,6 +44,7 @@ struct rz_sysc_signal {
> > >   * @offset: SYSC SoC ID register offset
> > >   * @revision_mask: SYSC SoC ID revision mask
> > >   * @specific_id_mask: SYSC SoC ID specific ID mask
> > > + * @extended_device_identification: SoC-specific extended device
> > > + identification
> > >   */
> > >  struct rz_sysc_soc_id_init_data {
> > >         const char * const family;
> > > @@ -49,6 +52,9 @@ struct rz_sysc_soc_id_init_data {
> > >         u32 offset;
> > >         u32 revision_mask;
> > >         u32 specific_id_mask;
> > > +       void (*extended_device_identification)(struct device *dev,
> > > +               void __iomem *sysc_base,
> > > +               struct soc_device_attribute *soc_dev_attr);
> >
> > That's a rather long name...
>
> Will be shortened in v2. I'm thinking of ext_dev_id().

What about print_id() or print_ext_id(), which is what the function really does?

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds