Re: [PATCH v7 2/2] rust: add dma coherent allocator abstraction.

[Abdiel Janulgue]

On 13/12/2024 16:27, Alice Ryhl wrote:
> > +    /// Returns the base address to the allocated region and the dma handle. The caller takes
> > +    /// ownership of the returned resources.
> > +    pub fn into_parts(self) -> (usize, bindings::dma_addr_t) {
> > +        let ret = (self.cpu_addr as _, self.dma_handle);
> > +        core::mem::forget(self);
> > +        ret
> > +    }
>
> Not only does this skip the destructor of `dma_free_attrs`. It also
> skips the destructor of fields including the `dev` field. Did you
> intend to leave the refcount on `struct device` without decrementing
> it?

Good catch. Yeah dev should be decremented here as well.
Will incorporate fix into next revision.

Regards,
Abdiel